Drop event recorder from shard lease lock #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
added
breaking
timebertt
force-pushed
the
lease-event-recorder
branch
from
188fe5b to
9b4fd80
Compare
timebertt
force-pushed
the
lease-event-recorder
branch
from
9b4fd80 to
f1c3a89
Compare
github-project-automation
bot
moved this from In progress
to Done
in kubernetes-controller-sharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Setting an event recorder on the shard lease lock before setting up the manager was not very pragmatic.
Also, recording events on shard leases isn't meaningful.
Hence, this PR drops the event recorder handling from the shard lease lock for simplicity.
Which issue(s) this PR fixes:
Fixes n/a
Special notes for your reviewer: